firecracker-microvm / firecracker-microvm/firecracker-go-sdk

`ip=` for IPv6

Open
#686 3 comments 1 reaction 0 assignees View on GitHub
Dominant language
Go
Stars
672
Forks
166
PR merge metrics
No merged PRs in 30d

Description

I believe this is a bug report, but maybe it is a feature request.

When attempting to use an IPv6 network with Fireactions (https://github.com/hostinger/fireactions), the chosen IPv6 address is not enclosed in square brackets, resulting in an incorrect configuration.

According to https://dracut-ng.github.io/dracut-ng/man/dracut.cmdline.7.html#_network, IPv6 addresses have to be put into square brackets.

Sadly, https://docs.kernel.org/admin-guide/nfs/nfsroot.html says nothing about the format of the `ip=` parameter that would help with the syntax of the IP address, but I guess that we need square brackets since this is the delimiter for the `ip=` parameter.

Since I am not an expert, I wanted to ask/discuss what the best way forward is. My best guess is that a patch is needed for `vmconf.go` for the method `IPBootParam`. Is this enough or even the right place?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.