firecracker-microvm / firecracker-microvm/firecracker-go-sdk

Merge PR #574 to pass log level through jailer if set

Open
#580 0 comments 0 reactions 0 assignees View on GitHub
firecracker v1.5.0 firecracker-feature
Dominant language
Go
Stars
672
Forks
166
PR merge metrics
No merged PRs in 30d

Description

Once we upgrade fireracker-go-sdk to support firecracker v1.5.0 api we should rea-dd #574 since with v1.5.0 we no longer need to pass log-path with log-level option.

This will require updating [setupLogging](https://github.com/firecracker-microvm/firecracker-go-sdk/blob/main/machine.go#L683) method to enable this behavior

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.