firecracker-microvm / firecracker-microvm/firecracker-go-sdk
Remove `addVsocksHandler` from `loadSnapshotHandlerList`
- Dominant language
- Go
- Stars
- 672
- Forks
- 166
- PR merge metrics
- No merged PRs in 30d
Description
According to the firecracker OpenAPI specification [^1], creating vsock
devices is only a pre-boot request, so adding vsocks after loading a
snapshot fails. It also seems redundant, since the VM loaded from a
snapshot restores vsocks anyways.
[^1]: https://github.com/firecracker-microvm/firecracker/blob/56aeeac51c00b449a45be4542b3e807d34690ba7/src/api_server/swagger/firecracker.yaml#L676-L678
Contributor guide
Research direction
Locate the loadSnapshotHandlerList entry point and its addVsocksHandler call, then read the surrounding snapshot-loading handler setup. Use the linked Firecracker OpenAPI specification to confirm vsock creation is pre-boot only; done means the redundant handler is removed without breaking snapshot loading.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100