firecracker-microvm / firecracker-microvm/firecracker-containerd

volume subdir has no `integ-test` Makefile rule

Open
#701 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
2.9k
Forks
247
PR merge metrics
No merged PRs in 30d

Description

Right now the top level Makefile uses a list of sub-directories to target running integration tests:

https://github.com/firecracker-microvm/firecracker-containerd/blob/279a03c70541cd355f4f4a8adda0480fbc6fb95d/Makefile#L14-L16

For example, the `volume` directory is included in this list, but its Makefile does not contain an `integ-test` rule, resulting in failure. The integration test(s) for volume live under the `snapshotter` directory.

Is there a reason why volume integ tests are under `snapshotter` ? If there is, we can just add a no-op `integ-test` rule to the volume Makefile. If not, maybe we can refactor to just pull that test into the volume directory.

e: answering the above question: volume is provided as a package and consumed in the volume integ test. moving this test to the volume dir would introduce an import cycle.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.