firebase / firebase/snippets-web

Unclear that tests actually validate their results?

Open
#222 3 comments 0 reactions 1 assignee Claimed by @morganchen12 View on GitHub
Dominant language
JavaScript
Stars
802
Forks
285
PR merge metrics
No merged PRs in 30d

Description

https://github.com/firebase/snippets-web/blob/c5bfca32e881d7a40002285384a784749f973c35/firestore/test.solution-counters.js#L49

In the test group that starts at the above line, it isn't clear to me that the results of the tests are actually being tested? What validates that the counters are created? What validates that the incremented value is correct?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.