firebase / firebase/quickstart-ios

Firestore sample sign in should notify on failure

Open
#876 0 comments 0 reactions 1 assignee Claimed by @morganchen12 View on GitHub
bug
Dominant language
Swift
Stars
3k
Forks
1.5k
Avg merge
2d 5h
Merged PRs (30d)
3

Description

The Firestore sample has a sign in page but doesn't actually validate if a sign in was successful or not - on a project that's misconfigured and has a bad API request back it will dismiss the sign in view and act as though a user is signed in. This will then later crash the app since it tries to force-unwrap the `currentUser` property on `Auth`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.