firebase / firebase/geofire-objc

GeoFire Circle Query NSException

Open
#129 2 comments 1 reaction 0 assignees View on GitHub
Dominant language
Objective-C
Stars
447
Forks
183
PR merge metrics
No merged PRs in 30d

Description

When using GeoFire circle query in Swift with GeoFire 3.0 cocoapod, query aborts with NSException with radius of 8000 Km (4791 MI)
Xcode debugger shows latitude of 105.9793939... and longitude of -112.05707936...
Radius is derived from user pan/zoom of map - i.e. user zooms out on map to display the entire world on the map. Firebase database contains locations all over the world and app is attempting to display markers. Seems like the GeoHash routine should restrict the latitude at +/- 90 and the longitude at +/- 180 and in that case all GeoFire data should be returned from the Query.
[GeoFire issue.pdf](https://github.com/firebase/geofire-objc/files/3854580/GeoFire.issue.pdf)

Contributor guide

Open the contributing guide

Research direction

Reproduce the GeoFire circle query with an 8000 km radius or a world-level map zoom, then inspect the GeoHash routine when it produces latitude 105.9793939. The fix is complete when the query no longer raises NSException and returns locations across the world while respecting latitude and longitude bounds.

Written by the indexing model from the issue text.

Assessment

Tech stack
firebase, objective-c, swift
Domain
databases, mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.