firebase / firebase/functions-samples

nextjs-with-firebase-hosting sample appears to document a sub-optimal configuration

Open
#763 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
12.2k
Forks
3.8k
Avg merge
3d 23h
Merged PRs (30d)
1

Description

This sentence at the beginning of https://github.com/firebase/functions-samples/tree/master/nextjs-with-firebase-hosting is strange:

> Host your SSR Next.js app on Cloud Functions with Firebase Hosting rewrite rules. Using a rewrite rule that catches ALL routes we can then host our SSR app on our Firebase Hosting URL instead of the Firebase Cloud Function URL.

This isn't what most people are going to want. You want to serve the static files that are generated by next.js from Firebase Hosting, and non-static files from a cloud function. A rewrite rule that catches all routes doesn't seem like a solution to using Firebase for next.js.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.