firebase / firebase/firebase-tools

failed initial V2 function deploy leaves it in wrong type of trigger state

Open
#8,298 1 comment 0 reactions 1 assignee Assigned to @taeold View on GitHub
api: functions triaged type: feature request
Dominant language
TypeScript
Stars
4.5k
Forks
1.3k
Avg merge
1d 12h
Merged PRs (30d)
84

Description

### [REQUIRED] Environment info

**firebase-tools:** 13.31.2

**Platform:** Ubuntu-based

### [REQUIRED] Test case

Deploy a NEW V2 background function in Node that references something in a parent directory's node_modules.

### [REQUIRED] Steps to reproduce

Deploy function. Allow it to fail. Fix or remove bad reference. Deploy function again.

### [REQUIRED] Expected behavior

Second deploy will succeed.

### [REQUIRED] Actual behavior

First deploy fails during deploy because the container build can't reference the package in a parent directory's node_modules. This is expected. When this is fixed and deploy attempted again, you find that firebase-tools left the function that failed to build as http triggered which blocks updating it. If it fails, it should clean up what it did so that you're in a state to deploy the fixed version.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.