firebase / firebase/firebase-tools
Improve Yarn PnP Support in `serveAdmin` for Firebase Functions Deployment
Open
api: functions
type: feature request
- Dominant language
- TypeScript
- Stars
- 4.5k
- Forks
- 1.3k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 84
Description
The `serveAdmin` function in [src/deploy/functions/runtimes/node/index.ts](https://github.com/firebase/firebase-tools/blob/f4a982f5c505bae47e63f5043ae978ebb9ef8d52/src/deploy/functions/runtimes/node/index.ts#L165) does not support Yarn Plug’n’Play (PnP). It searches for `.bin/firebase-functions`, but PnP environments do not have a `node_modules` folder, making these lookups unnecessary.
Instead, `serveAdmin` should detect Yarn PnP (`process.versions.pnp`) and execute `yarn firebase-functions` directly. Maybe there is also a better way to do this.
Would this be feasible to implement?
Contributor guide
Assessment
This issue has not been assessed yet.