firebase / firebase/firebase-tools
Missing dependency - `on-finished`
- Dominant language
- TypeScript
- Stars
- 4.5k
- Forks
- 1.3k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 84
Description
### [REQUIRED] Environment info
**firebase-tools:**13.23.1
**Platform:**macOS
### [REQUIRED] Test case
Firebase Data Connect VS extension errors out with `Error: Cannot find module 'on-finished'`
### [REQUIRED] Steps to reproduce
Simply run the extension, any command (init dataconnect , start emulator, etc...)
### [REQUIRED] Expected behavior
should either complete the task, or fail for environmental reasons.
### [REQUIRED] Actual behavior
Executing task: npx -y firebase-tools@latest init dataconnect --project fiteasy-7aa8d
node:internal/modules/cjs/loader:1093
throw err;
^
Error: Cannot find module 'on-finished'
Require stack:
- /Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/finalhandler/index.js
- /Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/express/lib/application.js
- /Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/express/lib/express.js
- /Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/express/index.js
- /Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/emulator/functionsEmulator.js
- /Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/emulator/controller.js
- /Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/emulator/commandUtils.js
- /Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/commands/database-get.js
- /Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/commands/index.js
- /Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/index.js
- /Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/bin/firebase.js
at Module._resolveFilename (node:internal/modules/cjs/loader:1090:15)
at Module._load (node:internal/modules/cjs/loader:934:27)
at Module.require (node:internal/modules/cjs/loader:1157:19)
at require (node:internal/modules/helpers:119:18)
at Object. (/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/finalhandler/index.js:17:18)
at Module._compile (node:internal/modules/cjs/loader:1275:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1329:10)
at Module.load (node:internal/modules/cjs/loader:1133:32)
at Module._load (node:internal/modules/cjs/loader:972:12)
at Module.require (node:internal/modules/cjs/loader:1157:19) {
code: 'MODULE_NOT_FOUND',
requireStack: [
'/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/finalhandler/index.js',
'/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/express/lib/application.js',
'/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/express/lib/express.js',
'/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/express/index.js',
'/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/emulator/functionsEmulator.js',
'/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/emulator/controller.js',
'/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/emulator/commandUtils.js',
'/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/commands/database-get.js',
'/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/commands/index.js',
'/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/index.js',
'/Users/segevs/.npm/_npx/ba4f1959e38407b5/node_modules/firebase-tools/lib/bin/firebase.js'
]
}
Node.js v19.7.0
* The terminal process "/bin/zsh '-l', '-c', 'npx -y firebase-tools@latest init dataconnect --project fiteasy-7aa8d'" terminated with exit code: 1.
* Terminal will be reused by tasks, press any key to close it.
Contributor guide
Assessment
This issue has not been assessed yet.