firebase / firebase/firebase-tools

Regression (hosting): `13.4.0` does not set oauth authorized domains for preview deploy

Open
#6,828 3 comments 11 reactions 1 assignee Claimed by @aalej View on GitHub
api: auth reproducible type: bug
Dominant language
TypeScript
Stars
4.5k
Forks
1.3k
Avg merge
1d 12h
Merged PRs (30d)
84

Description

### [REQUIRED] Environment info

**firebase-tools:** 13.4.0 (from `npx firebase-tools@latest` from `FirebaseExtended/action-hosting-deploy`)

**Platform:** Ubuntu (GitHub actions runner)

### [REQUIRED] Test case
```
npx firebase-tools@latest hosting:channel:deploy your_preview --only stage --expires 5d --project yourproject --json
```
### [REQUIRED] Steps to reproduce

Run it on a project that require google auth. (Firebase auth using firebaseUI)

### [REQUIRED] Expected behavior

Window pops up for you to log in; and no error logging in.

### [REQUIRED] Actual behavior

No window popus up, unauthorized error right away since the preview domain is now allow-listed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.