firebase / firebase/firebase-tools

Graceful Cleanup is a problem for clients that continuously profile

Open
#3,111 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
4.5k
Forks
1.3k
Avg merge
1d 12h
Merged PRs (30d)
84

Description

https://github.com/firebase/firebase-tools/blob/d162aec2334c29d3a1ad1a0ee91448b8b0ff8346/src/profiler.ts#L14

The profiler previously used to clean up its tmp files after report generation. Now it uses graceful cleanup means it doesn't clean up until the process exits.

This is a problem because this assumes that the profiler is run adhoc. We run the profiler continuously and then export that data to big query. With the introduction of this change our service now runs out of memory since the tmp folder is never cleaned.

This change was introduced here: https://github.com/firebase/firebase-tools/pull/2804

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.