firebase / firebase/firebase-js-sdk

typescript minimum version not indicated by peer dependency

Open
#8,837 4 comments 0 reactions 0 assignees View on GitHub
api: core bug stack:React
Dominant language
TypeScript
Stars
5.1k
Forks
1k
Avg merge
2d 21h
Merged PRs (30d)
37

Description

### Operating System

Linux

### Environment (if applicable)

Typescript

### Firebase SDK Version

11.4.0

### Firebase SDK Product(s)

Installations

### Project Tooling

React app via React-scripts (Create React App)

### Detailed Problem Description

Updated to latest firebase dependency and the typescript compile failed for firebase having type modifiers on import names. So the current version requires typescript to be at least 4.5 to support that, but it's not indicated by the package.json dependencies.

### Steps and code to reproduce issue

Use typescript before 4.5 and see a typescript compile fail on the syntaxes like import {type MyType} from 'firebase'

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.