firebase / firebase/firebase-js-sdk
signInWithPopup() lacks API to pass size hints
- Dominant language
- TypeScript
- Stars
- 5.1k
- Forks
- 1k
- Avg merge
- 2d 21h
- Merged PRs (30d)
- 37
Description
### Operating System
Any
### Environment (if applicable)
Google Chrome 130.0.6723.58 (Official Build) (64-bit)
### Firebase SDK Version
10.12.0
### Firebase SDK Product(s)
Auth
### Project Tooling
Angular app.
### Detailed Problem Description
We use signInWithPopup() also with customOIDC providers. For some providers the popup cuts off the login button (at the button of the popup).
The window size is hardcoded to 500 x 600 in https://github.com/firebase/firebase-js-sdk/blob/b807119252dacf46b0122344c2b6dfc503cecde1/packages/auth/src/platform_browser/util/popup.ts#L36-L37
The parameters are not exposed publicly as it seems (please correct me if I am wrong).
In the past I could see the default for known providers in idp.js (see e.g. https://github.com/firebase/firebase-js-sdk/pull/2966/files).
The file was removed in a huge PR #5345, that is hard to read and reason to see where things went.
### Steps and code to reproduce issue
See problem desc
Contributor guide
Assessment
This issue has not been assessed yet.