firebase / firebase/firebase-js-sdk

Firestore should not access www.google.com, only *.googleapis.com

Open
#6,777 6 comments 6 reactions 0 assignees View on GitHub
api: firestore feature request
Dominant language
TypeScript
Stars
5.1k
Forks
1k
Avg merge
2d 21h
Merged PRs (30d)
37

Description

We are currently rolling out a Content Security Policy. While doing so, we noticed that Firestore sometimes connects to www.google.com, specifically https://www.google.com/images/cleardot.gif. This is because this URL is hardcoded in the webchannel transport:

https://github.com/google/closure-library/blob/7c5e8ef152adf9cc814875c42ab2a0244653b69c/closure/goog/labs/net/webchannel/netutils.js#L48

It would be best if Firestore would only connect to *.googleapis.com domains.

Contributor guide

Open the contributing guide

Research direction

Start with the linked Closure Library file closure/goog/labs/net/webchannel/netutils.js at the referenced line, then trace how Firestore's webchannel transport consumes that URL. Confirm how the transport is brought into the SDK and whether the requested change belongs there; done means Firestore no longer connects to www.google.com and uses only *.googleapis.com domains.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
api, networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.