firebase / firebase/firebase-js-sdk

foreground onMessage not triggered on Chrome Extension popup.html

Open
#5,851 1 comment 0 reactions 0 assignees View on GitHub
api: messaging feature request needs-attention v9
Dominant language
TypeScript
Stars
5.1k
Forks
1k
Avg merge
2d 21h
Merged PRs (30d)
37

Description

### [REQUIRED] Describe your environment

* Operating System version: macOS 12.0.1
* Browser version: Chrome 96
* Firebase SDK version: 9.6.1
* Firebase Product: cloud messaging

### [REQUIRED] Describe the problem

These lines ignore all chrome extension, however, popup.html doesn't fit this situation.

It would be great to add something like this: `client.url.startsWith('chrome-extension://') && client.url.includes('popup.html')`

https://github.com/firebase/firebase-js-sdk/blob/3d8109ca30eb0433f5d0f32aad9a0360785f293c/packages/messaging/src/listeners/sw-listeners.ts#L214-L222

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.