firebase / firebase/firebase-js-sdk

[FR] auth useEmulator normalize definition

Open
#4,781 4 comments 3 reactions 0 assignees View on GitHub
feature request testing-sdk
Dominant language
TypeScript
Stars
5.1k
Forks
1k
Avg merge
2d 21h
Merged PRs (30d)
37

Description

The definition of `useEmulator` function in most of packages (`firestore`, `functions`, ...) use 2 params : `host` and `port`
![image](https://user-images.githubusercontent.com/36707217/114555038-9e84cd00-9c67-11eb-82c4-41c60fd73fd0.png)

But in the package `auth` the function `useEmulator` take only 1 param : `url`
![image](https://user-images.githubusercontent.com/36707217/114554016-8d878c00-9c66-11eb-9a9c-a5c890dfb2f4.png)

I don't know if there is a reason about these differences If there isn't, it would be interesting to normalize this with same definition for all package : `useEmulator(host, port)`

Contributor guide

Open the contributing guide

Research direction

Compare the useEmulator definitions in the auth package with those in firestore and functions, starting from the package API declarations and existing emulator tests. Confirm whether auth has a reason to accept only a URL; if not, normalize the public signature and update its tests so host-and-port usage is covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authentication
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.