firebase / firebase/firebase-js-sdk
FR: updateProfile() should return the updated user values
- Dominant language
- TypeScript
- Stars
- 5.1k
- Forks
- 1k
- Avg merge
- 2d 21h
- Merged PRs (30d)
- 37
Description
This issue is mostly to understand why updateProfile method doesn't return the updated user in the promise callback ?
Firebase is ok to manage user, but what's the point to update a user and not getting the new user value back ?
If i make a register form, with the first name and last name, i need to create a user with email and password, then call update profile to update the display name, but i will not be able to save those value in my state, so when the user is redirected to is account page i need to do an other request to get the updated value.
Same way when i update the photoUrl. update is maked, update of the photoUrl is ok, but then i need to trigger a reload of the data to get the new value and update the account settings.
It's a realy wierd way to do it i think.
But maybe i don't see the point, but i will rather user database to store all user values.
Contributor guide
Research direction
Start at the updateProfile() API entry point and trace its promise callback behavior for displayName and photoUrl updates. Define what the callback should return for the updated user values, then verify that registration and profile-update flows can use that result without another request; the issue names no files or tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- firebase, typescript
- Domain
- authentication
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100