firebase / firebase/firebase-ios-sdk
Fix FIAM SwiftUI colors
Open
api: inappmessaging
- Dominant language
- C++
- Stars
- 6.7k
- Forks
- 1.8k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 75
Description
SwiftUI preview support for FIAM was added in #8351. However, it was only tested for iOS and broke the tvOS CI because of using unsupported tvOS colors in SwiftUIPreviewHelpers.swift for `backgroundColor`, `primaryButtonBackgroundColor`, and `secondaryButtonBackgroundColor`. A placeholder fix was added in #8403 to fix CI.
The default colors still need to be reviewed in the sample app at `FirebaseInAppMessaging/Swift/Tests/Integration/FIAMSwiftUI/` and updated to work well for both iOS and tvOS previews.
Consider an additional check within these helpers that returns a light or dark color (for tvOS) based on interface style.
Contributor guide
Assessment
This issue has not been assessed yet.