firebase / firebase/firebase-ios-sdk
Make @DocumentID property wrapper conform to the Sendable Protocol
Open
api: firestore
Swift API
type: feature request
Xcode 13 - iOS 15
- Dominant language
- C++
- Stars
- 6.7k
- Forks
- 1.8k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 75
Description
The @DocumentID property wrapper for Firestore does not conform to the concurrency protocol Sendable in the upcoming Swift 5.5. Conformance to Sendable will be very important for types that need to be used with Actors. This document provides more details: https://github.com/apple/swift-evolution/blob/main/proposals/0302-concurrent-value-and-concurrent-closures.md
We can override the compiler with @unchecked annotation on the type but I'm hesitant to do that without a confirmation that @DocumentID can in fact be safely Sendable
Contributor guide
Assessment
This issue has not been assessed yet.