firebase / firebase/firebase-ios-sdk

FR: using memory mapped buffers for file writes in Crashlytics

Open
#5,764 6 comments 0 reactions 1 assignee Claimed by @samedson View on GitHub
api: crashlytics type: feature request
Dominant language
C++
Stars
6.7k
Forks
1.8k
Avg merge
2d 18h
Merged PRs (30d)
75

Description

### Feature proposal

* Firebase Component: Crashlytics

This is not so much a feature request as an RFC, since I'm happy to open a PR with this change and I just want to get consensus on it first. In `FIRCLSFileWriteToFileDescriptorOrBuffer` we see that a hard decision is made between durability and speed by having the option to buffer. We also see a `write` syscall when the buffering is done, which is of course expensive. If we use mmap instead, we can do fast, unbuffered writes directly to kernel memory. We can have our cake and eat it too.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.