firebase / firebase/firebase-ios-sdk

FR: Callable function on Trace object that lets us cancel the trace without logging it, rather than using stop

Open
#1,951 4 comments 2 reactions 0 assignees View on GitHub
api: performance type: feature request
Dominant language
C++
Stars
6.7k
Forks
1.8k
Avg merge
2d 18h
Merged PRs (30d)
75

Description

Sometimes if the ViewController changes while a trace is in progress, we want to abandon the trace as the VC may or may not finish the process we're tracking. Calling stop() on the trace will log an incomplete trace, which is not what we want as it will negatively affect the average elapsed time reported in the console. I couldn't find any indication that this feature already exists, but it'd be great if we could call something like cancel() on the trace to abort it without logging the results. Basically the same thing as stop() just without the reporting to Firebase.

Thanks!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.