firebase / firebase/firebase-ios-sdk

[FR]: Re-raising signal for other handlers to catch

Open
#13,693 1 comment 0 reactions 0 assignees View on GitHub
api: crashlytics type: feature request
Dominant language
C++
Stars
6.7k
Forks
1.8k
Avg merge
2d 18h
Merged PRs (30d)
75

Description

### Description

Since we register the signal handler ourselves first, Crashlytics will overwrite our signal handler when it registers the signal handler again. So I expect Crashlytics to re-raise the captured signal in [FIRCLSSignalHandler](https://github.com/firebase/firebase-ios-sdk/blob/95eb9dfe8bb2cca361522ec93436afebcb998f2a/Crashlytics/Crashlytics/Handlers/FIRCLSSignal.c#L327).

### API Proposal

_No response_

### Firebase Product(s)

Crashlytics

Contributor guide

Open the contributing guide

Research direction

Start in Crashlytics/Crashlytics/Handlers/FIRCLSSignal.c at FIRCLSSignalHandler, and review how Crashlytics registers and captures signals. Verify the interaction with another handler such as Crashlytics' registration scenario, then ensure the captured signal is re-raised so other handlers can catch it. Done means the requested signal propagation behavior is covered by appropriate tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, objective-c
Domain
observability-sre
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.