firebase / firebase/firebase-ios-sdk

[FR]: Avoid if it's possible hardcoded strings to reduce framework size

Open
#13,295 6 comments 0 reactions 1 assignee Claimed by @dconeybe View on GitHub
api: firestore type: feature request
Dominant language
C++
Stars
6.7k
Forks
1.8k
Avg merge
2d 14h
Merged PRs (30d)
72

Description

### Description

I'm wondering if is possible reduce the comments in asserts and string hardcoded that could have no impact in clients sdks, because they are for development purposes.
Doing this the binary size could be reduced.

As examples, of what a binary nowadays contains because it uses firebase.
https://github.com/firebase/firebase-ios-sdk/blob/fcdb55405b7f4c32d0068f902fac42defe63fefd/Firestore/core/src/remote/exponential_backoff.cc#L68
https://github.com/firebase/firebase-ios-sdk/blob/fcdb55405b7f4c32d0068f902fac42defe63fefd/Firestore/core/src/util/filesystem_win.cc#L137
https://github.com/firebase/firebase-ios-sdk/blob/fcdb55405b7f4c32d0068f902fac42defe63fefd/Firestore/Source/API/FSTUserDataReader.mm#L296
https://github.com/firebase/firebase-ios-sdk/blob/fcdb55405b7f4c32d0068f902fac42defe63fefd/Firestore/Source/API/FSTUserDataReader.mm#L584
https://github.com/firebase/firebase-ios-sdk/blob/fcdb55405b7f4c32d0068f902fac42defe63fefd/Firestore/core/src/util/random_access_queue.h#L111

### API Proposal

_No response_

### Firebase Product(s)

AB Testing, Analytics, App Check, App Distribution, Authentication, Crashlytics, Database, DynamicLinks, Firestore, Functions, In-App Messaging, Installations, ML Model Downloader, Messaging, Performance, Remote Config, Storage, Vertex AI

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.