firebase / firebase/firebase-functions
Add CorsOptions support to https.onCall in v2 functions
Open
api: http
feature request
- Dominant language
- TypeScript
- Stars
- 1.1k
- Forks
- 232
- Avg merge
- 20h 46m
- Merged PRs (30d)
- 15
Description
In v2, `cors` param on `https.onCall` should accept `cors.CorsOptions` object like on `v1`, the frontend app keeps sending check for CORS (OPTIONS) before every request because there isn't no maxAge set.
I can make a pull request for this, let me know what you think.
Contributor guide
Research direction
Start at the v2 https.onCall entry point and compare its cors handling with the v1 behavior described in the issue. Trace how CorsOptions and maxAge are currently handled, then verify that an options object is accepted and that the resulting callable requests no longer require a CORS preflight on every request.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- firebase, typescript
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100