firebase / firebase/firebase-android-sdk
AppDistribution - Latest version which fixed ` Missing app id. Please check that it was passed in and try again` not working for APK splits
- Dominant language
- Java
- Stars
- 2.6k
- Forks
- 710
- Avg merge
- 2d 23h
- Merged PRs (30d)
- 34
Description
Hi,
```
com.google.gms.google-services:4.4.1
com.google.firebase.appdistribution:4.2.0
```
I read there was an issue with previous versions where GMS broke AppDistribution, and then AppDistribution issues an fix.
All is working for my non-apk split project.
However, for the one with apk split, there was a need to register task per ABI manually like this (prior 4.x app distribution)
```
tasks.register("appDistributionUpload${abiName.capitalize()}${variant.name.capitalize()}", com.google.firebase.appdistribution.gradle.UploadDistributionTask) {
artifactPath = output.outputFile.absolutePath
serviceCredentialsFile = project.file("secrets/ci-firebase-account.json").absolutePath
releaseNotes = abi
}
```
Now after upgrading to the latest, this also produces the known (https://github.com/firebase/firebase-android-sdk/issues/5349)
```
Using APK path specified by the artifactPath parameter in your app's build.gradle: /Users/ursus/AndroidStudioProjects/o2-selfcare-android/mo2-android/radost/app/build/outputs/apk/tstFaceRecoDev/release/app__tstDevRelease_arm64-v8a_f008e376cb__05-03-2024__v1-24_200179907.apk.
Uploading APK to Firebase App Distribution...
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':foo:app:appDistributionUploadArm64v8aTstDevRelease'.
> Missing app id. Please check that it was passed in and try again
```
Could you please elaborate what was your fix, which fixed the non-apk split default behavior? It seems to me I need to "set" it manually here as well, since I'm registering a new Task
Contributor guide
Research direction
Start with the app's build.gradle and the manually registered UploadDistributionTask for the ABI-specific APK split. Reproduce appDistributionUploadArm64v8aTstDevRelease with the shown artifactPath and credentials, then compare it with the default non-split App Distribution task; done means the custom split task receives the app identity and uploads without the missing-app-id failure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android
- Domain
- build-system, release
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100