firebase / firebase/firebase-android-sdk

Incorrect assumption in `successor` and `predecessor` methods.

Open
#3,079 4 comments 0 reactions 1 assignee Claimed by @jmwski View on GitHub
api: database
Dominant language
Java
Stars
2.6k
Forks
710
Avg merge
2d 9h
Merged PRs (30d)
31

Description

https://github.com/firebase/firebase-android-sdk/blob/c56a9769b723bb96551ed2aa9fd3731e541ca018/firebase-database/src/main/java/com/google/firebase/database/core/utilities/PushIdGenerator.java#L69

The methods incorrectly assume that the keys are all in the style of the autogenerated RTDB keys, while in fact they may be any allowed key.

See the iOS SDK issue and solution (work in progress) here:

https://github.com/firebase/firebase-ios-sdk/issues/8790

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.