firebase / firebase/firebase-admin-go

option.WithAuthCredentials is broken

Open
#721 1 comment 0 reactions 0 assignees View on GitHub
needs-triage
Dominant language
Go
Stars
1.3k
Forks
274
Avg merge
10h 39m
Merged PRs (30d)
2

Description

`option.WithAuthCredentials` is presently (v4.18.0) broken in 2 places:

1. "google.golang.org/api@v0.231.0" will not properly switch to using the "new auth lib". A newer version of google API library is required, such as the recent "google.golang.org/api@v0.249.0".
2. `option.WithScopes`, used at present by the implementation will have no effect when `option.WithAuthCredentials` is specified (assuming p.1). The scopes must be given directly to the constructor of the whatever `auth.Credentials` object needed; at least this is the case with `externalaccount.NewCredentials`.
3. Because of the above, I'd say `internal.FirebaseScopes` shall be exported from externally visible package. Those scopes are already publicly advertised API feature, not some sort of internal detail (https://developers.google.com/identity/protocols/oauth2/scopes).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.