firebase / firebase/firebase-admin-dotnet

Replace HttpClientFactory as interface

Open
#287 7 comments 3 reactions 0 assignees View on GitHub
needs-triage
Dominant language
C#
Stars
408
Forks
146
Avg merge
22h 7m
Merged PRs (30d)
1

Description

Hello.

In the GoogleApi repository, an implementation of `Google.Apis.Http.IHttpClientFactory` using `Microsoft.Extensions.Http.IHttpMessageHandlerFactory` is presented.

https://github.com/googleapis/google-api-dotnet-client/issues/1756

https://github.com/googleapis/google-api-dotnet-client/blob/bfc9090dc2fae5b06a654328c4da7bc6b05b66f1/Src/Support/IntegrationTests/HttpClientFromMessageHandlerFactoryTests.cs#L38

To apply this method to Firebase as well, change the type of the `AppOptions.HttpClientFactory` property from `Google.Apis.Http.HttpClientFactory` to `Google.Apis.Http.IHttpClientFactory`?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.