firebase / firebase/fastlane-plugin-firebase_app_distribution

Action `firebase_app_distribution_get_latest_release` considers `createTime` instead of `buildVersion`

Open
#390 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Ruby
Stars
192
Forks
33
PR merge metrics
No merged PRs in 30d

Description

### Issue Description
`firebase_app_distribution_get_latest_release` implements `list_project_app_releases` from Google API's `FirebaseappdistributionV1`, passing page size 1, as shown on the snippet below:

https://github.com/firebase/fastlane-plugin-firebase_app_distribution/blob/bdc1358767af1063962a56e04e09a7b4c4c1eafd/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_get_latest_release.rb#L17-L34

This by default returns the latest release by `createTime`. However, considering the context of mobile app releases versioning standards, the `buildVersion` parameter would be more consistent to determine which release is in fact the latest (build version number for a new release should always be greater than the previous, as enforced by public app stores - Google Play, App Store).

My suggestion is to either change this implementation to consider buildVersion as parameter to find the most recent release, or add an optional parameter to `firebase_app_distribution_get_latest_release`, so the developer can select which parameter to use.

##### Environment

| Library | Version |
| ----------- | ----------- |
| fastlane | 2.228.0 |
| fastlane-plugin-firebase_app_distribution | v0.10.1 |

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.