firebase / firebase/FirebaseUI-Flutter

firebase_ui_oauth: Pre-compile svg icon assets using `vector_graphics_compiler`

Open
#247 3 comments 4 reactions 0 assignees View on GitHub
enhancement Keep Open oauth
Dominant language
Dart
Stars
151
Forks
141
Avg merge
2d 10h
Merged PRs (30d)
3

Description

### Discussed in https://github.com/firebase/FirebaseUI-Flutter/discussions/240

Originally posted by **aebrahim** January 4, 2024
The social login icons are packaged as strings containing the raw svg, which are then rendered using `flutter_svg`. However, under the hood, using `flutter_svg` means also including its dependency `vector_graphics_compiler` with the application, which at runtime converts raw svg to a compiled `VectorGraphic` to display.

Given that the svg string is known at build time, it is possible to pre-compile it as a `VectorGraphic` at build time. Advantages:
1. Would no longer pull in the `vector_graphics_compiler` dependency, which adds ~180 KB to the build.
2. Slightly more efficient runtime as the precompiled `VectorGraphic` can be a const.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.