finos / finos/tracdap

Search API response when no matches found

Open
#47 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Java
Stars
55
Forks
18
Avg merge
6h 29m
Merged PRs (30d)
16

Description

The search API currently returns an empty object if there is no match found. I propose that this is modified to be

{searchResult: []}

which will mean that downstream code will not have to check for the property.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the search API entry point and trace the response produced when no matches are found. Confirm the current empty-object behavior and identify the existing search response tests, then update the behavior so no-match responses contain searchResult: [] and verify downstream expectations.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.