finos / finos/regular-table

Simple repro of height bug when trying to get a `<regular-table>` to participate in a flex layout

Open
#124 1 comment 0 reactions 0 assignees View on GitHub
question
Dominant language
JavaScript
Stars
403
Forks
43
Avg merge
3m
Merged PRs (30d)
1

Description

## The repro

I came up with a simple repro of the issue I was having in #115:

https://bl.ocks.org/telamonian/00c777c2194e11f43bd7ade294095aa1

## The "bug"

The `` element renders as zero height.

## Description

In the above example, there's an `#outer` flex box that contains two children:
- a simple `` with some text content
- a `` with ~15,000 data rows

In order to get a `` element to participate in a flex layout, you have to change it's `position` (or wrap it in a `

` and change the position of that) to something other than `absolute` (I think maybe it has to be `position: relative`, not 100% sure). As soon as you change `position`, though, the `` disappears. The only resolution seems to be to set an explicit height in `px` on at least one of the parent elements of the ``. In theory, the height of the `` should be taken care of by the flex layout.

Is this a bug or not? If it is a bug, how do we fix it?

My sense is that there's a tweak to some virtual size calculation somewhere in `scroll_body.js` that will allow for height to be controlled by the flex layout

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.