finos / finos/git-proxy

Make `uiRouteAuth` more flexible

Open
#1,296 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
249
Forks
176
Avg merge
3d 8h
Merged PRs (30d)
20

Description

Currently, the `uiRouteAuth` option in the config enforces auth requirements for certain routes:

```json
"uiRouteAuth": {
"enabled": false,
"rules": [
{
"pattern": "/dashboard/*",
"adminOnly": false,
"loginRequired": true
},
{
"pattern": "/admin/*",
"adminOnly": true,
"loginRequired": true
}
]
}
```

The issue is that these routes can be arbitrarily defined in `routes.tsx`, so we would need some way to make sure that the patterns are actually matching to existing routes, or otherwise be able to define the routes dynamically in the config as well.

**Additional context**
https://github.com/finos/git-proxy/pull/1268

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.