finos / finos/a11y-theme-builder

[TB] Add pre-commit hook to enforce prettier, linting

Open
#960 9 comments 0 reactions 0 assignees View on GitHub
enhancement theme builder app
Dominant language
TypeScript
Stars
82
Forks
77
PR merge metrics
No merged PRs in 30d

Description

## Problem/Concern

Stemming from https://github.com/finos/a11y-theme-builder/pull/948#issuecomment-2200477209, it was suggested that we should have a pre-commit hook in Theme Builder to enforce Prettier formatting and linting so that we know that code being sent for code review won't have to spend much time on formatting issues.

## Proposed Solution

Create a pre-commit hook so that committed code will have the correct formatting and linting.

Contributor guide

No contributing guide indexed for this repository

Research direction

No file or test is named. Start by locating the repository's existing formatting and linting commands and the Git hook configuration; done means commits run both checks and reject code that fails them.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, nodejs, typescript
Domain
developer-experience, tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.