finos / finos/TimeBase-CE

TickDB client has incorrect logging - missing %s placeholders

Open Beginner friendly
#347 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
132
Forks
23
Avg merge
3m
Merged PRs (30d)
1

Description

[Here](https://github.com/finos/TimeBase-CE/blob/release-6.2/java/timebase/client/src/main/java/com/epam/deltix/qsrv/hf/tickdb/comm/client/SafeDisconnectableEventHandler.java#L42)

and [here](https://github.com/finos/TimeBase-CE/blob/release-6.2/java/timebase/client/src/main/java/com/epam/deltix/qsrv/hf/tickdb/comm/client/SafeDisconnectableEventHandler.java#L57)

Consider using https://github.com/epam/gflog/blob/main/SKILL.md

User visible defect:

```
GapFillerServiceIntTest > backfillNoDataIsNonFatal() STANDARD_ERROR
java.lang.IllegalStateException: log entry is committed
at com.epam.deltix.gflog.core.service.LogLocalEntry.warnCommitted(LogLocalEntry.java:984)
at com.epam.deltix.gflog.core.service.LogLocalEntry.verifyNotCommitted(LogLocalEntry.java:967)
at com.epam.deltix.gflog.core.service.LogLocalEntry.with(LogLocalEntry.java:761)
at com.epam.deltix.gflog.core.service.LogLocalEntry.with(LogLocalEntry.java:12)
at com.epam.deltix.qsrv.hf.tickdb.comm.client.SafeDisconnectableEventHandler.onDisconnected(SafeDisconnectableEventHandler.java:59)
at com.epam.deltix.qsrv.hf.tickdb.comm.client.TickDBClient$ConnectionNotificationTask.run(TickDBClient.java:1945)
at com.epam.deltix.util.concurrent.QuickExecutor$Worker.run(QuickExecutor.java:266)
at java.base/java.lang.Thread.run(Thread.java:1583)
```

Contributor guide

Open the contributing guide

Research direction

Start with java/timebase/client/src/main/java/com/epam/deltix/qsrv/hf/tickdb/comm/client/SafeDisconnectableEventHandler.java at lines 42 and 57, then read gflog's SKILL.md for the logging-call requirements. Run GapFillerServiceIntTest, especially backfillNoDataIsNonFatal(), to reproduce the committed log entry failure. Done means both logging calls follow the required placeholders and the test no longer reports this exception.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
observability
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
86/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.