final-form / final-form/react-final-form

onSubmit type signature - is callback really optional?

Open
#1,003 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
7.4k
Forks
497
PR merge metrics
No merged PRs in 30d

Description

### Are you submitting a **bug report** or a **feature request**?

bug report

### What is the current behavior?

https://final-form.org/docs/react-final-form/types/FormProps#onsubmit

```
callback?: (errors?: SubmissionErrors) => void,
```

### What is the expected behavior?

```
callback: (errors?: SubmissionErrors) => void,
```

I believe `callback` parameter is passed everytime, it's just matter of function itself if it wants to use it.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.