finagle / finagle/finch

Allow users override maxInMemoryFileSize in multipartFileUpload

Open
#1,087 1 comment 0 reactions 0 assignees View on GitHub
easy enhancement help wanted
Dominant language
Scala
Stars
1.6k
Forks
217
PR merge metrics
No merged PRs in 30d

Description

It was asked [on Gitter](https://gitter.im/finagle/finch?at=5c6f1c2de5eeec0d9ba469f9). Here is the argument we need to wire: https://github.com/twitter/finagle/blob/develop/finagle-base-http/src/main/scala/com/twitter/finagle/http/exp/MultipartDecoder.scala#L20

Contributor guide

Open the contributing guide

Research direction

Start at the multipartFileUpload entry point and read the linked finagle-base-http/src/main/scala/com/twitter/finagle/http/exp/MultipartDecoder.scala definition to understand the maxInMemoryFileSize argument. Trace how multipartFileUpload constructs or invokes the decoder, then check the existing multipart upload coverage; done means callers can override that limit while the current default behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
backend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.