fin-hypergrid / fin-hypergrid/core

data model options

Open
#634 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
907
Forks
139
PR merge metrics
No merged PRs in 30d

Description

@Dwaynekj Hey DJ, While refining/updating issue #614 (v3 prep), I came across your change to the calling signature of the data source constructor, which I’m sure you recall was in support of group view's tree column.

You added two parameters to the constructor. While pertinent to the current “standard” datamodel, it is meaningless to a generic “black box” datamodel, which should not need to support those parameters.

I propose changing it to a generic options object. I'll post a PR.

cc:@dcchuck

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.