files-community / files-community/Files

Bug: Changed data will be lost when page is switched in properties window

Open
#14,506 3 comments 0 reactions 0 assignees View on GitHub
area - properties window
Dominant language
C#
Stars
45.4k
Forks
2.9k
Avg merge
19h 7m
Merged PRs (30d)
62

Description

### Description

If you changed properties in a certain tab, that changes will be lost after you switched tabs.

### Steps To Reproduce

1. Go to folder properties window
2. Go to Customization tab
3. Change icon without tapping Save button
4. Go to General tab
5. Go back to Customization tab

Your icon selected is no longer selected.

### Requirements

I think it'd be better to instance all ViewModels of properties tab and put them into a list and use them every time frame content is changed instead of instancing new one.

### Files Version

3.0.0

### Windows Version

10.0.22000

### Log File

No logs because it's not unexpected behavior but implemented behavior.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the folder properties window flow through the Customization and General tabs, then inspect how each tab's ViewModel is created when the frame content changes. The issue is done when an unsaved icon selection remains selected after switching away from and back to the Customization tab.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.