filecoin-project / filecoin-project/lily

Pitfall: id addresses without robust address

Open
#402 4 comments 0 reactions 0 assignees View on GitHub
kind/bug kind/schema
Dominant language
Go
Stars
52
Forks
47
PR merge metrics
No merged PRs in 30d

Description

### Describe the bug:

The `id_addresses` table does not contain things like f0122 or anything that was hardcoded into genesis. These may not have a robust address counterpart.

This means queries joining on id_addresses will fail to work with those unless this information is known by the person making the query (not obvious).

We could manually add genesis addresses to this table (with an empty `address`). However I wonder if this is suboptimal if more addresses are created on future network upgrades.

This is also related to #212. We cannot consolidate on robust addresses if some actors simply don't have them. We would have to consolidate on id addresses instead.

### Visor Version: master

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.