filecoin-project / filecoin-project/go-state-types

Update `OnMinerSectorsTerminateParams` and `VerifyDealsForActivationParams` param types in market actor

Open
#408 0 comments 0 reactions 0 assignees View on GitHub
good first issue help wanted
Dominant language
Go
Stars
28
Forks
41
Avg merge
17h 3m
Merged PRs (30d)
2

Description

Market actor field type mismatch:

- OnMinerSectorsTerminateParams:
- In market actor `OnMinerSectorsTerminateParams` from v13 onwards we have switched to `sectors` from `DealIDs` and sector is a `bitfield` in [builtin-actor](https://github.com/filecoin-project/builtin-actors/blob/0f205c378983ac6a08469b9f400cbb908eef64e2/actors/market/src/types.rs#L60) but in [go-state-types](https://github.com/filecoin-project/go-state-0types/blob/03987dc0ea56c28d1ee4c349e43fb029eddb4e82/builtin/v13/market/market_types.go#L77) it is still `[]DealID`.

- VerifyDealsForActivationParams:
- In [builtin-actor](https://github.com/filecoin-project/builtin-actors/blob/a96db01f5c42fce94472af4e8a9f19edd913fa64/actors/market/src/types.rs#L82) from V13 onwards the `SectorDeals` inside the `VerifyDealsForActivationParams` has the [sector_number](https://github.com/filecoin-project/builtin-actors/blob/a96db01f5c42fce94472af4e8a9f19edd913fa64/actors/market/src/types.rs#L82) field but in [go-state-types](https://github.com/filecoin-project/go-state-types/blob/03987dc0ea56c28d1ee4c349e43fb029eddb4e82/builtin/v13/market/market_types.go#L38) it's not there.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.