filecoin-project / filecoin-project/filecoin-pin

`add` demands CreateDataSet scope even when the target data set already exists

Open
#677 0 comments 0 reactions 0 assignees View on GitHub
team/filecoin-pin team/fs-wg
Dominant language
TypeScript
Stars
26
Forks
21
Avg merge
5d 18h
Merged PRs (30d)
27

Description

The requirement is static because the preflight runs at Synapse setup, before data-set resolution — at that point the flow doesn't know whether it will create a data set or just add pieces to an existing one. So it asks for the worst case.

Consequence: a least-privilege key scoped to `AddPieces` only (exactly the kind of key the scoped-sessions feature encourages) can't run `add` against an existing data set, even though the operation it would actually perform is fully authorized. The gating error tells the owner to grant `CreateDataSet` for an upload that will never create anything.

Same pattern check is worth doing for `import` (same upload flow) when fixing.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.