filecoin-project / filecoin-project/boost

Refactor `Funds` page and tagging functionality

Open
#726 0 comments 3 reactions 0 assignees View on GitHub
area/funds area/ui area/ux
Dominant language
Go
Stars
121
Forks
79
Avg merge
10d 14h
Merged PRs (30d)
1

Description

At the moment in Boost we have Funds tagging functionality (for `PublishStorageDeals` message and for deal collateral) as well as an overview of a few wallets and functionality to move funds to escrow for deal collateral.

While this is somewhat informative and provides some visibility over what funds an SP must hold to accept deals, it is unfortunately not an exhaustive set of required funds, and we can't make a decision whether to accept/reject a deal just on that information.

The idea behind the `Funds` page and feature was to tag/untag funds and have a high confidence that the SP has enough funds for the deal to be put on chain into a sector and the sector to be continuously proven. We can't achieve this without tapping into wallets configured on `lotus-miner` side and coding various heuristics in order to make a decision whether a deal can be accepted/rejected

---

Because of the complexity described above, after a chat with Dirk, we have decided that we should refactor the Funds functionality in the following way:
- display read-only information about all control and worker and owner wallets from `lotus-miner`
- continue to display information about deal collateral and market escrow
- remove functionality for tagging/untagging of funds when accepting deals

Ultimately for now it will be up to the user to maintain funds in all relevant wallets, so that deals are accepted and stored successfully on the miner.

Contributor guide

Open the contributing guide

Research direction

Start by locating the Funds page and its tagging/untagging handlers, then trace how Boost reads lotus-miner wallets, deal collateral, and market escrow. Done means the page shows the specified wallet and escrow information while tagging and untagging functionality is removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend, full-stack
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.