filecoin-project / filecoin-project/boost

Stream reset in deal handling after 30 seconds

Open
#1,850 6 comments 0 reactions 0 assignees View on GitHub
kind/bug need/triage
Dominant language
Go
Stars
121
Forks
79
Avg merge
10d 14h
Merged PRs (30d)
1

Description

### Checklist

- [X] This is **not** a question or a support request. If you have any boost related questions, please ask in the [discussion forum](https://github.com/filecoin-project/boost/discussions).
- [X] This is **not** a new feature request. If it is, please file a [feature request](https://github.com/filecoin-project/boost/issues/new?assignees=&labels=need%2Ftriage%2Ckind%2Ffeature&template=feature_request.yml) instead.
- [X] This is **not** an enhancement request. If it is, please file a [improvement suggestion](https://github.com/filecoin-project/boost/issues/new?assignees=&labels=need%2Ftriage%2Ckind%2Fenhancement&template=enhancement.yml) instead.
- [X] I **have** searched on the [issue tracker](https://github.com/filecoin-project/boost/issues) and the [discussion forum](https://github.com/filecoin-project/boost/discussions), and there is no existing related issue or discussion.
- [X] I am running the [`Latest release`](https://github.com/filecoin-project/boost/releases), or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
- [ ] I did not make any code changes to boost.

### Boost component

- [X] boost daemon - storage providers
- [ ] boost client
- [ ] boost UI
- [ ] boost data-transfer
- [ ] boost index-provider
- [ ] Other

### Boost Version

```text
boostd v2.1.1
```

### Describe the Bug

When deals come in and they get handled, this can take > 30 seconds (see https://github.com/filecoin-project/boost/issues/1747)

When that happens, the underlaying stream connection gets killed by *something*.
Not the deal handler itself.

### Logging Information

```text
no
```

### Repo Steps

- Add a sleep of > 30 seconds in your deal filter handling.
- Make a deal
- See that you get a stream reset on the client
- See that once your provider succeeds, it shows an err: stream reset on closing it too ([here](https://github.com/filecoin-project/boost/blob/main/storagemarket/lp2pimpl/net.go#L298-L302))

Note that [upgrading the timeouts here](https://github.com/filecoin-project/boost/blob/main/storagemarket/lp2pimpl/net.go#L42-L53) does not help. (I've changed them to 60, and it still happens)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.