filecoin-project / filecoin-project/boost

publish fund tagging doesn't take deals/msg into account

Open
#1,348 6 comments 0 reactions 0 assignees View on GitHub
area/funds area/ui kind/bug
Dominant language
Go
Stars
121
Forks
79
Avg merge
10d 14h
Merged PRs (30d)
1

Description

### Checklist

- [X] This is **not** a question or a support request. If you have any boost related questions, please ask in the [discussion forum](https://github.com/filecoin-project/boost/discussions).
- [X] This is **not** a new feature request. If it is, please file a [feature request](https://github.com/filecoin-project/boost/issues/new?assignees=&labels=need%2Ftriage%2Ckind%2Ffeature&template=feature_request.yml) instead.
- [X] This is **not** an enhancement request. If it is, please file a [improvement suggestion](https://github.com/filecoin-project/boost/issues/new?assignees=&labels=need%2Ftriage%2Ckind%2Fenhancement&template=enhancement.yml) instead.
- [X] I **have** searched on the [issue tracker](https://github.com/filecoin-project/boost/issues) and the [discussion forum](https://github.com/filecoin-project/boost/discussions), and there is no existing related issue or discussion.
- [X] I am running the [`Latest release`](https://github.com/filecoin-project/boost/releases), or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
- [X] I did not make any code changes to boost.

### Boost component

- [X] boost daemon - storage providers
- [ ] boost client
- [X] boost UI
- [ ] boost data-transfer
- [ ] boost index-provider
- [ ] Other

### Boost Version

```text
latest
```

### Describe the Bug

boost tags funds per deal and not per message. based on lotus publish fee settings that tags way to many funds

[edit]

math was most likely off - sorry for the hastly issue. i think it goes way beyond a simple fix, even one would be appreciated.

if this is still a "thing" in around 3-4 weeks we will come back to this and make some more productive proposals on how to fix this (caught up in something else right now that needs the attention until then)

### Logging Information

```text
not needed
```

### Repo Steps

1. Run '...'
2. Do '...'
3. See error '...'
...

Contributor guide

Open the contributing guide

Research direction

Start by tracing publish fund tagging in the Boost daemon and compare its per-deal behavior with the Lotus publish fee settings mentioned in the report. The issue provides no file or test entry point, so first establish how deals and messages are represented and confirm whether funds are over-tagged. Done means an agreed accounting model, corrected tagging, and regression coverage for the reported case.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.