filecoin-project / filecoin-project/boost
boost deal --verified default true allows for easy mistakes
- Dominant language
- Go
- Stars
- 121
- Forks
- 79
- Avg merge
- 10d 14h
- Merged PRs (30d)
- 1
Description
### Checklist
- [X] This is **not** a question or a support request. If you have any boost related questions, please ask in the [discussion forum](https://github.com/filecoin-project/boost/discussions).
- [X] This is **not** a new feature request. If it is, please file a [feature request](https://github.com/filecoin-project/boost/issues/new?assignees=&labels=need%2Ftriage%2Ckind%2Ffeature&template=feature_request.yml) instead.
- [X] This is **not** an enhancement request. If it is, please file a [improvement suggestion](https://github.com/filecoin-project/boost/issues/new?assignees=&labels=need%2Ftriage%2Ckind%2Fenhancement&template=enhancement.yml) instead.
- [X] I **have** searched on the [issue tracker](https://github.com/filecoin-project/boost/issues) and the [discussion forum](https://github.com/filecoin-project/boost/discussions), and there is no existing related issue or discussion.
- [X] I am running the [`Latest release`](https://github.com/filecoin-project/boost/releases), or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
- [X] I did not make any code changes to boost.
### Boost component
- [ ] boost daemon - storage providers
- [X] boost client
- [ ] boost UI
- [ ] boost data-transfer
- [ ] boost index-provider
- [ ] Other
### Boost Version
```text
latest
```
### Describe the Bug
`--verified` defaults to true
this leads to `--verified false` defaulting to true too. one needs to explicitly write `--verified=false` to not send accidently verified deals
please think about having the `--verified` flag default to false.
(this is a known problem with ufav client)
### Logging Information
```text
not needed
```
### Repo Steps
1. Run '...'
2. Do '...'
3. See error '...'
...
Contributor guide
Research direction
Start by locating the boost client definition of the --verified flag and trace how its default and explicit value are passed into deal creation. Exercise the client command with the flag omitted, set to false, and set to true; done means omitted and false values do not send verified deals, while true still does.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100