filecoin-project / filecoin-project/boost

Take tagged funds in consideration when moving funds to escrow

Open
#1,320 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
121
Forks
79
Avg merge
10d 14h
Merged PRs (30d)
1

Description

We need to take tagged funds in consideration when moving funds to escrow in case where single wallet is being used for PSD and collateral.

Screenshot 2023-03-22 at 6 28 36 PM

```
// MoveFundsToEscrow moves funds from the deal collateral wallet into escrow with
// the storage market actor
func (m *FundManager) MoveFundsToEscrow(ctx context.Context, amt abi.TokenAmount) (cid.Cid, error) {
msgCid, err := m.api.MarketAddBalance(ctx, m.cfg.CollatWallet, m.cfg.StorageMiner, amt)
if err != nil {
return cid.Undef, fmt.Errorf("moving %d to escrow wallet %s: %w", amt, m.cfg.StorageMiner, err)
}

return msgCid, err
}
```

Contributor guide

Open the contributing guide

Research direction

Locate the MoveFundsToEscrow entry point shown in the issue and trace how MarketAddBalance selects funds from the collateral wallet. Reproduce the shared-wallet case for PSD and collateral, then verify that tagged funds are considered when moving the requested amount to escrow.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.