fibercrypto / fibercrypto/skywallet-mcu

Passphrase not supported for signing transactions

Open
#250 0 comments 0 reactions 0 assignees View on GitHub
enhancement firmware skycoin stdev wip
Dominant language
C
Stars
2
Forks
5
PR merge metrics
No merged PRs in 30d

Description

**Feature description**

Support passphrase for signin transactions

**Is your feature request related to a problem? Please describe.**
If passphrase is configured on device then Skywallet manages an address sequence different from using no passphrase at all . Transaction signing handler does neither seems to be aware of this nor even offers .

**Describe the solution you'd like**
Implement `usePassphrase` in `msgTransactionSignImpl` and `fsm_msgTransactionSign`

**Describe alternatives you've considered**
This has to be implemented for consistency with other functions.

**Additional context**
Needs similar issues in client libraries.

**Possible implementation**

- [ ] Read device settings and use passphrase if option set
- [ ] Add optional `usePassphrase` in message to force using (ignoring) passphrase if value set
- [ ] If passphrase set derive master node from master seed prior to signing Skycoin transaction.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.